]> code.ossystems Code Review - openembedded-core.git/commitdiff
ncurses_6.0: Improve reproducibility
authorJuro Bystricky <juro.bystricky@intel.com>
Fri, 31 Mar 2017 21:28:13 +0000 (14:28 -0700)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Sat, 1 Apr 2017 07:16:27 +0000 (08:16 +0100)
Build static libraries without the binutils "ar" -U option.
This option deliberately breaks deterministic mode.
The option seems to be a relic from 2015, intended as a workaround
for some unspecified build problems.

[YOCTO#11247]

Signed-off-by: Juro Bystricky <juro.bystricky@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-core/ncurses/files/configure-reproducible.patch [new file with mode: 0644]
meta/recipes-core/ncurses/ncurses_6.0+20161126.bb

diff --git a/meta/recipes-core/ncurses/files/configure-reproducible.patch b/meta/recipes-core/ncurses/files/configure-reproducible.patch
new file mode 100644 (file)
index 0000000..54a8bdc
--- /dev/null
@@ -0,0 +1,20 @@
+"configure" enforces -U for ar flags, breaking deterministic builds.
+The flag was added to fix some vaguely specified "recent POSIX binutil
+build problems" in 2015. 
+
+Upstream-Status: Pending
+Signed-off-by: Juro Bystricky <juro.bystricky@intel.com>
+
+diff --git a/configure b/configure
+index 7f31208..aa80911 100755
+--- a/configure
++++ b/configure
+@@ -4428,7 +4428,7 @@ if test "${cf_cv_ar_flags+set}" = set; then
+ else
+       cf_cv_ar_flags=unknown
+-      for cf_ar_flags in -curvU -curv curv -crv crv -cqv cqv -rv rv
++      for cf_ar_flags in -curv curv -crv crv -cqv cqv -rv rv
+       do
+               # check if $ARFLAGS already contains this choice
index e95741f4c32db752c94ee03ef0ed8faa4f0c071b..ace3108007ed3223d3a7b6df42b3f89854d433ae 100644 (file)
@@ -3,6 +3,7 @@ require ncurses.inc
 SRC_URI += "file://tic-hang.patch \
             file://fix-cflags-mangle.patch \
             file://config.cache \
+            file://configure-reproducible.patch \
 "
 # commit id corresponds to the revision in package version
 SRCREV = "3db0bd19cb50e3d9b4f2cf15b7a102fe11302068"