]> code.ossystems Code Review - openembedded-core.git/commitdiff
glibc-locale: Fix build error with PACKAGE_NO_GCONV = "1"
authorJason Wessel <jason.wessel@windriver.com>
Tue, 2 Jul 2019 20:16:08 +0000 (13:16 -0700)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Wed, 3 Jul 2019 08:09:50 +0000 (09:09 +0100)
When the PACKAGE_NO_GCONV is set to 1 an empty directory is left behind from the do_install rule:

=====
ERROR: glibc-locale-2.29-r0 do_package: QA Issue: glibc-locale: Files/directories were installed but not shipped in any package:
  /usr/lib
  /usr/lib/locale
Please set FILES such that these items are packaged. Alternatively if they are unneeded, avoid installing them or delete them within do_install.
glibc-locale: 2 installed and not shipped files. [installed-vs-shipped]
ERROR: glibc-locale-2.29-r0 do_package: Fatal QA errors found, failing task.
=====

The simple fix is to prune the empty directory.

Signed-off-by: Jason Wessel <jason.wessel@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-core/glibc/glibc-locale.inc

index f033635bd0d3127c16727e844f635e9887b42693..bf5eaee93804414ba6d53376c4c33f318d3bd1a6 100644 (file)
@@ -87,6 +87,9 @@ do_install() {
        if [ ${PACKAGE_NO_GCONV} -eq 0 ]; then
                copy_locale_files ${libdir}/gconv 0755
                copy_locale_files ${datadir}/i18n 0644
+       else
+               # Remove the libdir if it is empty when gconv is not copied
+               find ${D}${libdir} -type d -empty -delete
        fi
        copy_locale_files ${datadir}/locale 0644
        install -m 0644 ${LOCALETREESRC}/SUPPORTED ${WORKDIR}/SUPPORTED