populate-volatile.sh: don't spawn background process at rootfs time

If we're building a read-only rootfs, we'll get the following error now
and then.

    tar: .: file changed as we read it

The root cause is that we spawn background process at rootfs time.
When the tar command is running, it's possible that files under rootfs
are changed by background processes, thus this error.

[YOCTO #4937]

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>

diff --git a/meta/recipes-core/initscripts/initscripts-1.0/populate-volatile.sh b/meta/recipes-core/initscripts/initscripts-1.0/populate-volatile.sh
index 6b3830883b136403b09cd5f7f4f697ffed45f0f8..0ff0e1af7f20e430d38ae96ec636c055b532f8c7 100755 (executable)
--- a/meta/recipes-core/initscripts/initscripts-1.0/populate-volatile.sh
+++ b/meta/recipes-core/initscripts/initscripts-1.0/populate-volatile.sh
@@ -42,7 +42,7 @@ create_file() {
                        # but these failures should not be logged to make sure the do_rootfs
                        # process doesn't fail. This does no harm, as this script will
                        # run on target to set up the correct files and directories.
-                       eval $EXEC > /dev/null 2>&1 &
+                       eval $EXEC > /dev/null 2>&1
                fi
        }
 }
@@ -87,7 +87,7 @@ link_file() {
        else
                # For the same reason with create_file(), failures should
                # not be logged.
-               eval $EXEC > /dev/null 2>&1 &
+               eval $EXEC > /dev/null 2>&1
        fi
 }
 
@@ -156,7 +156,7 @@ apply_cfgfile() {
                [ "${TTYPE}" = "l" ] && {
                        TSOURCE="$TLTARGET"
                        [ "${VERBOSE}" != "no" ] && echo "Creating link -${TNAME}- pointing to -${TSOURCE}-."
-                       link_file "${TSOURCE}" "${TNAME}" &
+                       link_file "${TSOURCE}" "${TNAME}"
                        continue
                }