]> code.ossystems Code Review - openembedded-core.git/commitdiff
qemumachines: make MACHINE_FEATURES append follow qemu.inc include
authorTom Zanussi <tom.zanussi@intel.com>
Sun, 1 Jul 2012 15:56:12 +0000 (10:56 -0500)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Wed, 4 Jul 2012 14:00:40 +0000 (15:00 +0100)
qemu.inc does a straight assign to MACHINE_FEATURES so overwriting the
preceding append to MACHINE_FEATURES, so the MACHINE_FEATURES append
needs to be moved after the include.

This situation came about as a result of commit 71a4bf386:

    qemumachines: Enable xserver-xorg as default xserver

    For qemux86 and qemux86-64 include qemu.inc after defining XSERVER

which missed this side-effect (and maybe others).

Signed-off-by: Tom Zanussi <tom.zanussi@intel.com>
meta/conf/machine/qemux86-64.conf
meta/conf/machine/qemux86.conf

index 2e361a5cab5969837f8b08b1166902d2c928d25b..998ef60401b283cd8bde07787f84b1d65300e8bd 100644 (file)
@@ -7,8 +7,6 @@ PREFERRED_PROVIDER_virtual/libgl ?= "mesa-dri"
 
 require conf/machine/include/tune-x86_64.inc
 
-MACHINE_FEATURES += "x86"
-
 KERNEL_IMAGETYPE = "bzImage"
 
 SERIAL_CONSOLE = "115200 ttyS0"
@@ -24,6 +22,8 @@ XSERVER ?= "xserver-xorg \
 
 require conf/machine/include/qemu.inc
 
+MACHINE_FEATURES += "x86"
+
 GLIBC_ADDONS = "nptl"
 GLIBC_EXTRA_OECONF = "--with-tls"
 
index ad840c04989e13da87d74fc8847b67b021eae2e3..57e480c8515c091dee80541dc43d71eded60a499 100644 (file)
@@ -7,8 +7,6 @@ PREFERRED_PROVIDER_virtual/libgl ?= "mesa-dri"
 
 require conf/machine/include/tune-i586.inc
 
-MACHINE_FEATURES += "x86"
-
 KERNEL_IMAGETYPE = "bzImage"
 
 SERIAL_CONSOLE = "115200 ttyS0"
@@ -24,6 +22,8 @@ XSERVER ?= "xserver-xorg \
 
 require conf/machine/include/qemu.inc
 
+MACHINE_FEATURES += "x86"
+
 GLIBC_ADDONS = "nptl"
 GLIBC_EXTRA_OECONF = "--with-tls"