]> code.ossystems Code Review - openembedded-core.git/commitdiff
oe-buildperf-report: highlight large changes in the HTML report
authorRoss Burton <ross.burton@intel.com>
Thu, 26 Apr 2018 11:35:09 +0000 (12:35 +0100)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Fri, 11 May 2018 06:49:30 +0000 (07:49 +0100)
If the relative difference is greater than 2%, make the text bold to highlight
it.

Signed-off-by: Ross Burton <ross.burton@intel.com>
scripts/lib/build_perf/html/report.html
scripts/oe-build-perf-report

index 291ad9d72168a1b72368a7c33d77190c7ecb12a9..d1ba6f2578869663e07147f4f777ad3fb0313e90 100644 (file)
@@ -136,10 +136,13 @@ h3 {
             {% else %}
               {% set result_style = "color: orange" %}
             {%endif %}
+            {% if measurement.reldiff|abs > 2 %}
+              {% set result_style = result_style + "; font-weight: bold" %}
+            {% endif %}
             <td>{{ measurement.description }}</td>
             <td style="font-weight: bold">{{ measurement.value.mean }}</td>
             <td style="{{ result_style }}">{{ measurement.absdiff_str }}</td>
-            <td style="{{ result_style }}">{{ measurement.reldiff }}</td>
+            <td style="{{ result_style }}">{{ measurement.reldiff_str }}</td>
           </tr>
         {% endfor %}
       {% else %}
@@ -167,7 +170,7 @@ h3 {
             {% else %}
             <span style="color: orange">
             {% endif %}
-            {{ measurement.absdiff_str }} ({{measurement.reldiff}})
+            {{ measurement.absdiff_str }} ({{measurement.reldiff_str}})
             </span></span>
           </div>
           {# Table for trendchart and the statistics #}
index dc999c45c150cdebbcafed6ccd691552205bd203..0bd05f44ef0292aee204a064e70f6558293816de 100755 (executable)
@@ -416,9 +416,11 @@ def print_html_report(data, id_comp, buildstats):
                 samples[-1]['commit_num'] = commit_num
 
             absdiff = samples[-1]['val_cls'](samples[-1]['mean'] - samples[id_comp]['mean'])
+            reldiff = absdiff * 100 / samples[id_comp]['mean']
             new_meas['absdiff'] = absdiff
             new_meas['absdiff_str'] = str(absdiff) if absdiff < 0 else '+' + str(absdiff)
-            new_meas['reldiff'] = "{:+.1f} %".format(absdiff * 100 / samples[id_comp]['mean'])
+            new_meas['reldiff'] = reldiff
+            new_meas['reldiff_str'] = "{:+.1f} %".format(reldiff)
             new_meas['samples'] = samples
             new_meas['value'] = samples[-1]
             new_meas['value_type'] = samples[-1]['val_cls']