]> code.ossystems Code Review - openembedded-core.git/commitdiff
rootfs-postcommands: add test for unsatisfied RRECOMMENDS
authorJose Alarcon <jose.alarcon@ge.com>
Mon, 4 Sep 2017 05:12:24 +0000 (08:12 +0300)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Thu, 21 Sep 2017 15:52:05 +0000 (16:52 +0100)
The do_rootfs log contains a number of unsatisfied package
recommendations. At the moment those are only visible when
reviewing the rootfs log.

This patch adds an extra check to surface any unsatisfied
recommendation  as WARNINGS to the build output.

Enable this check with:
ROOTFS_POSTPROCESS_COMMAND += "rootfs_log_check_recommends;"

(From OE-Core rev: 9d049bf7941f30e35c51775684559e95185fba96)

Signed-off-by: Jose Alarcon <jose.alarcon@ge.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
meta/classes/rootfs-postcommands.bbclass

index a107d0e47288cec15c4824cb5463eff8a897f2a7..2503d89e285bc50140b59674581590f84f6a43f3 100644 (file)
@@ -305,3 +305,15 @@ python write_image_test_data() {
            os.remove(testdata_link)
         os.symlink(os.path.basename(testdata), testdata_link)
 }
+
+# Check for unsatisfied recommendations (RRECOMMENDS)
+python rootfs_log_check_recommends() {
+    log_path = d.expand("${T}/log.do_rootfs")
+    with open(log_path, 'r') as log:
+        for line in log:
+            if 'log_check' in line:
+                continue
+
+            if 'unsatisfied recommendation for' in line:
+                bb.warn('[log_check] %s: %s' % (d.getVar('PN', True), line))
+}