]> code.ossystems Code Review - openembedded-core.git/commitdiff
gstreamer-omx: Improve variable expansion of ${S}
authorRichard Purdie <richard.purdie@linuxfoundation.org>
Wed, 30 Sep 2015 13:53:51 +0000 (14:53 +0100)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Thu, 1 Oct 2015 06:40:36 +0000 (07:40 +0100)
The way ${S} is expanded into CFLAGS means the recipe is marked as depending
on the path within which its built. We can avoid this by avoiding the expansion
which then allows reuse of the recipe from sstate.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-multimedia/gstreamer/gstreamer1.0-omx.inc

index d698904349e2e58980ed91822b5dc242bc6e162c..26c13361fe414ae952106c2baaee451d8186660c 100644 (file)
@@ -20,11 +20,10 @@ EXTRA_OECONF += "--disable-valgrind --with-omx-target=${GSTREAMER_1_0_OMX_TARGET
 python __anonymous () {
     omx_target = d.getVar("GSTREAMER_1_0_OMX_TARGET", True)
     if omx_target in ['generic', 'bellagio']:
-        srcdir = d.getVar("S", True)
         # Bellagio headers are incomplete (they are missing the OMX_VERSION_MAJOR,#
         # OMX_VERSION_MINOR, OMX_VERSION_REVISION, and OMX_VERSION_STEP macros);
         # appending a directory path to gst-omx' internal OpenMAX IL headers fixes this
-        d.appendVar("CFLAGS", " -I%s/omx/openmax" % srcdir)
+        d.appendVar("CFLAGS", " -I${S}/omx/openmax")
     elif omx_target == "rpi":
         # Dedicated Raspberry Pi OpenMAX IL support makes this package machine specific
         d.setVar("PACKAGE_ARCH", d.getVar("MACHINE_ARCH", True))