]> code.ossystems Code Review - openembedded-core.git/commitdiff
wic: improve generating disk system identifier
authorJonathan Liu <net147@gmail.com>
Mon, 31 Jul 2017 10:53:39 +0000 (20:53 +1000)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Thu, 3 Aug 2017 10:14:04 +0000 (11:14 +0100)
This should reduce the chance of generating 0xffffffff as the disk
system identifier.

Signed-off-by: Jonathan Liu <net147@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
scripts/lib/wic/plugins/imager/direct.py

index 51bdd3a9849e83106d572569c25716953ebd25d6..5765bbb527b4628ba2c14cd1f2e57c2badc393cb 100644 (file)
@@ -26,6 +26,7 @@
 
 import logging
 import os
+import random
 import shutil
 import tempfile
 import uuid
@@ -303,7 +304,7 @@ class PartitionedImage():
                           # all partitions (in bytes)
         self.ptable_format = ptable_format  # Partition table format
         # Disk system identifier
-        self.identifier = int.from_bytes(os.urandom(4), 'little') or 0xffffffff
+        self.identifier = random.SystemRandom().randint(1, 0xffffffff)
 
         self.partitions = partitions
         self.partimages = []