]> code.ossystems Code Review - openembedded-core.git/commitdiff
sanity.bbclass: sanity check for if bitbake is present in PATH
authorDorinda <dorindabassey@gmail.com>
Tue, 26 Jan 2021 01:33:59 +0000 (02:33 +0100)
committerAnuj Mittal <anuj.mittal@intel.com>
Mon, 1 Feb 2021 05:43:10 +0000 (13:43 +0800)
If a user executes the environment script instead of sourcing it,
there's an error about an empty element in PATH. This is because
bitbake isn't present in environment variable PATH. Hence, this
patch adds a sanity check to verify if bitbake is present in
PATH and if bitbake isn't present issue a warning message.

[YOCTO #13822]

(From OE-Core rev: e08799913a7f207bc63e085eb98196fd61ed57bc)

Signed-off-by: Dorinda Bassey <dorindabassey@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit dbd80a923c9075d363f69ffd86b4392c210d668d)
Signed-off-by: Anuj Mittal <anuj.mittal@intel.com>
meta/classes/sanity.bbclass

index 0e7ad45c94e190089a136c8805dc35b3b1a68f7d..16275b2ea51bfa28c48983a1cf5383557ed759a5 100644 (file)
@@ -794,6 +794,11 @@ def check_sanity_everybuild(status, d):
     if "." in paths or "./" in paths or "" in paths:
         status.addresult("PATH contains '.', './' or '' (empty element), which will break the build, please remove this.\nParsed PATH is " + str(paths) + "\n")
 
+    #Check if bitbake is present in PATH environment variable
+    bb_check = bb.utils.which(d.getVar('PATH'), 'bitbake')
+    if not bb_check:
+        bb.warn("bitbake binary is not found in PATH, did you source the script?")
+
     # Check whether 'inherit' directive is found (used for a class to inherit)
     # in conf file it's supposed to be uppercase INHERIT
     inherit = d.getVar('inherit')