]> code.ossystems Code Review - openembedded-core.git/commitdiff
yocto-check-layer: Add additional README checks
authorDhruva Gole <goledhruva@gmail.com>
Tue, 30 Nov 2021 05:43:35 +0000 (11:13 +0530)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Fri, 3 Dec 2021 23:36:21 +0000 (23:36 +0000)
This adds:
- Test case to review if the README file specifies the maintainer.
- Test case to review if the README file specifies the word patch.
- Test case to review if the README file contains an email address.

[YOCTO #11131]

Signed-off-by: Dhruva Gole <goledhruva@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
scripts/lib/checklayer/cases/common.py

index 4495f71b2450d2b231c5b9a730095ba39be9526a..52c786f77b583161aeedc3595448d8e3e2ece98e 100644 (file)
@@ -6,6 +6,7 @@
 import glob
 import os
 import unittest
+import re
 from checklayer import get_signatures, LayerType, check_command, get_depgraph, compare_signatures
 from checklayer.case import OECheckLayerTestCase
 
@@ -25,6 +26,11 @@ class CommonCheckLayer(OECheckLayerTestCase):
             data = f.read()
         self.assertTrue(data,
                 msg="Layer contains a README file but it is empty.")
+        self.assertIn('maintainer',data)
+        self.assertIn('patch',data)
+        # Check that there is an email address in the README
+        email_regex = re.compile(r"[^@]+@[^@]+")
+        self.assertTrue(email_regex.match(data))
 
     def test_parse(self):
         check_command('Layer %s failed to parse.' % self.tc.layer['name'],