]> code.ossystems Code Review - openembedded-core.git/commitdiff
kernel.bbclass: remove unnecessary dead code
authorRasmus Villemoes <rasmus.villemoes@prevas.dk>
Thu, 23 Sep 2021 09:20:40 +0000 (11:20 +0200)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Sun, 26 Sep 2021 15:49:02 +0000 (16:49 +0100)
The grep pattern seems to have been wrong ever since we stopped adding
the -ffile-prefix-map via a patch in commit 20aea61385e, because the
actual upstream gcc produces

  -ffile-prefix-map=<old>=<new>

and not

  -ffile-prefix-map=<old=new>

Besides, these *-prefix-map options are already used when building the
kernel due to the setting of KERNEL_CC, and the kernel build system
itself also probes for and uses at least -fmacro-prefix-map (hence
taking care of __FILE__ etc., but not necessarily things that go in
.debug_info sections).

Signed-off-by: Rasmus Villemoes <rasmus.villemoes@prevas.dk>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes/kernel.bbclass

index d13c38fb0260f1a8a696185285707c48b643d8a4..4acec1877e00d626950b1f73156179f8129646a5 100644 (file)
@@ -322,15 +322,6 @@ python do_devshell:prepend () {
 
 addtask bundle_initramfs after do_install before do_deploy
 
-get_cc_option () {
-               # Check if KERNEL_CC supports the option "file-prefix-map".
-               # This option allows us to build images with __FILE__ values that do not
-               # contain the host build path.
-               if ${KERNEL_CC} -Q --help=joined | grep -q "\-ffile-prefix-map=<old=new>"; then
-                       echo "-ffile-prefix-map=${S}=/kernel-source/"
-               fi
-}
-
 kernel_do_compile() {
        unset CFLAGS CPPFLAGS CXXFLAGS LDFLAGS MACHINE
        if [ "${BUILD_REPRODUCIBLE_BINARIES}" = "1" ]; then
@@ -361,9 +352,8 @@ kernel_do_compile() {
                copy_initramfs
                use_alternate_initrd=CONFIG_INITRAMFS_SOURCE=${B}/usr/${INITRAMFS_IMAGE_NAME}.cpio
        fi
-       cc_extra=$(get_cc_option)
        for typeformake in ${KERNEL_IMAGETYPE_FOR_MAKE} ; do
-               oe_runmake ${typeformake} CC="${KERNEL_CC} $cc_extra " LD="${KERNEL_LD}" ${KERNEL_EXTRA_ARGS} $use_alternate_initrd
+               oe_runmake ${typeformake} CC="${KERNEL_CC}" LD="${KERNEL_LD}" ${KERNEL_EXTRA_ARGS} $use_alternate_initrd
        done
        # vmlinux.gz is not built by kernel
        if (echo "${KERNEL_IMAGETYPES}" | grep -wq "vmlinux\.gz"); then
@@ -390,8 +380,7 @@ do_compile_kernelmodules() {
                bbnote "KBUILD_BUILD_TIMESTAMP: $ts"
        fi
        if (grep -q -i -e '^CONFIG_MODULES=y$' ${B}/.config); then
-               cc_extra=$(get_cc_option)
-               oe_runmake -C ${B} ${PARALLEL_MAKE} modules CC="${KERNEL_CC} $cc_extra " LD="${KERNEL_LD}" ${KERNEL_EXTRA_ARGS}
+               oe_runmake -C ${B} ${PARALLEL_MAKE} modules CC="${KERNEL_CC}" LD="${KERNEL_LD}" ${KERNEL_EXTRA_ARGS}
 
                # Module.symvers gets updated during the 
                # building of the kernel modules. We need to