]> code.ossystems Code Review - openembedded-core.git/commitdiff
oe-init-build-env-memres: swap parameter order
authorPaul Eggleton <paul.eggleton@linux.intel.com>
Wed, 21 Jun 2017 19:49:54 +0000 (21:49 +0200)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Wed, 28 Jun 2017 14:51:55 +0000 (15:51 +0100)
This script expected the port number to be specified first, which is
somewhat counter-intuitive especially if you're used to
oe-init-build-env; besides, in local usage you are unlikely to need to
specify a custom port. Given that few people are using this yet (based
on the issues I have recently fixed), switch the arguments around so
that the two scripts behave consistently.

Signed-off-by: Paul Eggleton <paul.eggleton@linux.intel.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
oe-init-build-env-memres

index 9e1425ea83f06e37e854e1de06068533015dd25d..3f0d239a10ba4541167000b92194376902f37fe3 100755 (executable)
 # Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA  02111-1307  USA
 
 #
-# Normally this is called as '. ./oe-init-build-env-memres <portnumber> <builddir>'
+# Normally this is called as '. ./oe-init-build-env-memres <builddir> [portnumber]'
 #
 # This works in most shells (not dash), but not all of them pass the arguments
-# when being sourced.  To workaround the shell limitation use "set <portnumber>
-# <builddir>" prior to sourcing this script.
+# when being sourced.  To workaround the shell limitation use "set <builddir>
+# [portnumber]" prior to sourcing this script.
 #
-if [ -z "$1" ]; then
+if [ -z "$2" ]; then
     echo "No port specified, using dynamically selected port"
     port=-1
 else
-    port=$1
-    shift
+    port=$2
+    set -- "$1" "$3" "$4" "$5" "$6"
 fi
 
 if [ -n "$BASH_SOURCE" ]; then