]> code.ossystems Code Review - openembedded-core.git/commitdiff
shadow: improve reproducibility by hard-coding shell path
authorMartin Hundebøll <martin@geanix.com>
Wed, 7 Nov 2018 12:22:22 +0000 (13:22 +0100)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Tue, 13 Nov 2018 15:18:28 +0000 (15:18 +0000)
The shadow configure script tries really hard to detect the running
shell to make sure it doesn't do unsupported calls.

On my system the shell is detected as /bin/sh, while a build in an
ubuntu docker it resolves to /bin/bash. And since the shell path is
baked into the target binaries through config.h, the build becomes
inreproducible.

Fix reproducibility by hard-coding the shell to be /bin/sh

Signed-off-by: Martin Hundebøll <martin@geanix.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-extended/shadow/shadow.inc

index 0fa80a282a87f9eb54c643842a65458e44c946ce..09c37ef8a354c5b77d18268aeb6a2dfda632d4bd 100644 (file)
@@ -45,6 +45,8 @@ PAM_SRC_URI = "file://pam.d/chfn \
 
 inherit autotools gettext
 
+export CONFIG_SHELL="/bin/sh"
+
 EXTRA_OECONF += "--without-audit \
                  --without-libcrack \
                  --without-selinux \