]> code.ossystems Code Review - openembedded-core.git/commitdiff
package_manager: Fix support for NO_RECOMMENDATONS
authorRichard Röjfors <richard.rojfors@gmail.com>
Sun, 30 Jul 2017 09:12:56 +0000 (11:12 +0200)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Tue, 29 Aug 2017 10:54:24 +0000 (11:54 +0100)
When support for dnf was introduced the check of the
no NO_RECOMMENDATIONS variable got broken.

This fixes the issue by compairing to the string "1"
rather than the number 1.

Signed-off-by: Richard Röjfors <richard@puffinpack.se>
Signed-off-by: Ross Burton <ross.burton@intel.com>
(cherry picked from commit 1849ce3bd7c0af055f3e849a6508e746b6a0dca5)
Signed-off-by: Armin Kuster <akuster808@gmail.com>
meta/lib/oe/package_manager.py

index 93d079d73dbcf7d862503b19232964bc52ce2ee9..28c6b2aec28bb3ebb31f0a57d38d9d3f8f840cb6 100644 (file)
@@ -585,7 +585,7 @@ class RpmPM(PackageManager):
 
         output = self._invoke_dnf((["--skip-broken"] if attempt_only else []) +
                          (["-x", ",".join(exclude_pkgs)] if len(exclude_pkgs) > 0 else []) +
-                         (["--setopt=install_weak_deps=False"] if self.d.getVar('NO_RECOMMENDATIONS') == 1 else []) +
+                         (["--setopt=install_weak_deps=False"] if self.d.getVar('NO_RECOMMENDATIONS') == "1" else []) +
                          (["--nogpgcheck"] if self.d.getVar('RPM_SIGN_PACKAGES') != '1' else ["--setopt=gpgcheck=True"]) +
                          ["install"] +
                          pkgs)