]> code.ossystems Code Review - openembedded-core.git/commitdiff
Fix 7 references to undefined variables, as spotted by pyflakes
authorChris Larson <chris_larson@mentor.com>
Thu, 25 Mar 2010 00:48:49 +0000 (17:48 -0700)
committerRichard Purdie <rpurdie@linux.intel.com>
Thu, 25 Mar 2010 17:25:56 +0000 (17:25 +0000)
(Bitbake rev: e1e4ccf203e38070eeafd31a622671996cff61a1)

Signed-off-by: Chris Larson <chris_larson@mentor.com>
Signed-off-by: Richard Purdie <rpurdie@linux.intel.com>
bitbake/lib/bb/fetch/__init__.py
bitbake/lib/bb/runqueue.py
bitbake/lib/bb/taskdata.py
bitbake/lib/bb/utils.py

index 5616c79ab002dc3e49e34352b552d2f39b80c7d4..e6cc1c535b1aa6f60b3ab65bc1a4d31aa8a05e45 100644 (file)
@@ -128,7 +128,7 @@ def encodeurl(decoded):
     (type, host, path, user, pswd, p) = decoded
 
     if not type or not path:
-        fatal("invalid or missing parameters for url encoding")
+        bb.msg.fatal(bb.msg.domain.Fetcher, "invalid or missing parameters for url encoding")
     url = '%s://' % type
     if user:
         url += "%s" % user
@@ -477,7 +477,7 @@ def try_mirrors(d, uri, mirrors, check = False):
             try:
                 ud = FetchData(newuri, ld)
             except bb.fetch.NoMethodError:
-                bb.msg.debug(1, bb.msg.domain.Fetcher, "No method for %s" % url)
+                bb.msg.debug(1, bb.msg.domain.Fetcher, "No method for %s" % uri)
                 continue
 
             ud.setup_localpath(ld)
index 887cb5c2b637c65c23217925a4bfd99d0ec970be..c5f4380c8615419f8c2d1d76b6c6f7314cfbf6d4 100644 (file)
@@ -924,7 +924,7 @@ class RunQueue:
 
         if self.stats.total == 0:
             # nothing to do
-            self.state = runQueueCleanup
+            self.state = runQueueCleanUp
 
         while True:
             task = None
index 841d243e548e8b9bf0b63ceecef0f9c861ddecdd..3e5e006f5f13f42d9663f5898b014359b47fcc32 100644 (file)
@@ -174,7 +174,7 @@ class TaskData:
                 for dep in task_deps['depends'][task].split():
                     if dep:
                         if ":" not in dep:
-                            bb.msg.fatal(bb.msg.domain.TaskData, "Error, dependency %s does not contain ':' character\n. Task 'depends' should be specified in the form 'packagename:task'" % (depend, fn))
+                            bb.msg.fatal(bb.msg.domain.TaskData, "Error, dependency %s does not contain ':' character\n. Task 'depends' should be specified in the form 'packagename:task'" % (dep, fn))
                         ids.append(((self.getbuild_id(dep.split(":")[0])), dep.split(":")[1]))
                 self.tasks_idepends[taskid].extend(ids)
 
index 5b7e7a3608c96d84ec187b7307cfee69a9d5a722..ad0aa68b27d5b78036743db6eff92956d21c7808 100644 (file)
@@ -21,7 +21,8 @@ BitBake Utility Functions
 
 separators = ".-"
 
-import re, fcntl, os, types, bb, string
+import re, fcntl, os, types, bb, string, stat, shutil
+from commands import getstatusoutput
 
 def explode_version(s):
     r = []
@@ -516,7 +517,7 @@ def movefile(src,dest,newmtime=None,sstat=None):
                 return None # failure
         try:
             if didcopy:
-                missingos.lchown(dest,sstat[stat.ST_UID],sstat[stat.ST_GID])
+                os.lchown(dest,sstat[stat.ST_UID],sstat[stat.ST_GID])
                 os.chmod(dest, stat.S_IMODE(sstat[stat.ST_MODE])) # Sticky is reset on chown
                 os.unlink(src)
         except Exception, e:
@@ -536,8 +537,6 @@ def copyfile(src,dest,newmtime=None,sstat=None):
     attributes; mtime will be preserved even when moving across
     filesystems.  Returns true on success and false on failure.
     """
-    import os, stat, shutil
-
     #print "copyfile("+src+","+dest+","+str(newmtime)+","+str(sstat)+")"
     try:
         if not sstat: