]> code.ossystems Code Review - openembedded-core.git/commitdiff
poky-qemu-internal: use lockfile-progs for network interface locking
authorScott Garman <scott.a.garman@intel.com>
Wed, 29 Sep 2010 01:58:33 +0000 (18:58 -0700)
committerRichard Purdie <rpurdie@linux.intel.com>
Thu, 7 Oct 2010 18:52:32 +0000 (19:52 +0100)
The 'lockfile' utility originally used comes from the procmail
package, which users shouldn't have to install. This uses the
more general lockfile-progs utilities to acheive the same end.

This fixes [BUGID #389]

Signed-off-by: Scott Garman <scott.a.garman@intel.com>
scripts/poky-qemu-internal

index c65e0f1de277ea0e6edda531703bc12d46199037..c3720d9ce2dbba42ba8928fa68009f5ab1bc89bc 100755 (executable)
@@ -55,6 +55,13 @@ QEMUIFDOWN=`which poky-qemu-ifdown`
 
 NFSRUNNING="false"
 
+LOCKUTIL=`which lockfile-create`
+if [ -z "$LOCKUTIL" ]; then
+    echo "Error: Unable to find the lockfile-create utility"
+    echo "On Ubuntu systems this is included in the lockfile-progs package"
+    return
+fi
+
 LOCKDIR="/tmp/qemu-tap-locks"
 [ ! -d "$LOCKDIR" ] && mkdir $LOCKDIR
 
@@ -63,10 +70,14 @@ TAP=""
 LOCKFILE=""
 for tap in $POSSIBLE; do
     LOCKFILE="$LOCKDIR/$tap"
-    if lockfile -2 -r 1 $LOCKFILE; then
+    echo "Acquiring lockfile for $tap..."
+    if lockfile-create --use-pid -r 1 $LOCKFILE; then
+        # the --use-pid option to lockfile-create will give use
+        # the subshell's pid, so override it with the shell's pid:
+        echo $$ > $LOCKFILE.lock
         TAP=$tap
-        break;
-    fi 
+        break
+    fi
 done
 
 if [ "$TAP" = "" ]; then
@@ -79,7 +90,11 @@ if [ "$TAP" = "" ]; then
         return
     fi
     LOCKFILE="$LOCKDIR/$tap"
-    if lockfile $LOCKFILE; then
+    echo "Acquiring lockfile for $tap..."
+    if lockfile-create --use-pid -r 1 $LOCKFILE; then
+        # the --use-pid option to lockfile-create will give us
+        # the subshell's pid, so override it with the shell's pid:
+        echo $$ > $LOCKFILE.lock
         TAP=$tap
     fi 
 else
@@ -91,7 +106,7 @@ release_lock() {
         $QEMUIFDOWN $TAP $POKY_NATIVE_SYSROOT
     else
         echo "Releasing lockfile of preconfigured tap device '$TAP'"
-        rm -f $LOCKFILE
+        lockfile-remove $LOCKFILE
     fi
 
     if [ "$NFSRUNNING" = "true" ]; then