]> code.ossystems Code Review - openembedded-core.git/commitdiff
oe-build-perf-report-email.py: use pwd for getting user name
authorMarkus Lehtonen <markus.lehtonen@linux.intel.com>
Wed, 12 Apr 2017 19:17:32 +0000 (22:17 +0300)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Wed, 12 Apr 2017 22:55:53 +0000 (23:55 +0100)
Use pwd data instead of os.getlogin() to get the username for fallback
email address. os.getlogin() basically returns the name of the user
logged in on the controlling terminal of the process and raises an
exception on some systems if the process does not have a controlling
terminal - when executed from a cron script, for example.

Signed-off-by: Markus Lehtonen <markus.lehtonen@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
scripts/contrib/oe-build-perf-report-email.py

index 055a7b12cfeb9dd2abc7b562e1373eef0911b2fb..261ca514e5aef1ad8638b0cae4137cba93a51bd0 100755 (executable)
@@ -211,9 +211,10 @@ def send_email(text_fn, html_fn, subject, recipients):
     else:
         raise ReportError("Neither plain text nor html body specified")
 
-    full_name = pwd.getpwuid(os.getuid()).pw_gecos.split(',')[0]
+    pw_data = pwd.getpwuid(os.getuid())
+    full_name = pw_data.pw_gecos.split(',')[0]
     email = os.environ.get('EMAIL',
-                           '{}@{}'.format(os.getlogin(), socket.getfqdn()))
+                           '{}@{}'.format(pw_data.pw_name, socket.getfqdn()))
     msg['From'] = "{} <{}>".format(full_name, email)
     msg['To'] = ', '.join(recipients)
     msg['Subject'] = subject