]> code.ossystems Code Review - openembedded-core.git/commitdiff
kernel-devsrc: check for localversion files in the kernel source tree
authorBeniamin Sandu <beniaminsandu@gmail.com>
Thu, 11 Apr 2019 07:28:54 +0000 (10:28 +0300)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Thu, 11 Apr 2019 20:19:27 +0000 (21:19 +0100)
The kernel-devsrc rework doesn't take into account localversion
files in the kernel source tree. This might result in modules with an
incomplete version magic when building out-of-tree using the SDK.

Before:
root@qemux86:~# insmod hello.ko
[   42.000212] hello: version magic '5.0.3-yocto-standard SMP preempt
mod_unload PENTIUMM ' should be '5.0.3-my-custom-release-yocto-standard
SMP preempt mod_unload PENTIUMM '
[   42.008200] hello: version magic '5.0.3-yocto-standard SMP preempt
mod_unload PENTIUMM ' should be '5.0.3-my-custom-release-yocto-standard
SMP preempt mod_unload PENTIUMM '
insmod: can't insert 'hello.ko': invalid module format

After:
root@qemux86:~# insmod hello.ko
[   39.094288] hello: loading out-of-tree module taints kernel.
[   39.108044] Hello World!

Signed-off-by: Beniamin Sandu <beniamin.sandu@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-kernel/linux/kernel-devsrc.bb

index 69a8eaef815c435a1236d6e2b4abda1e0bcc9bbc..5ec5929735c92d6eed948be8f1e936880d71ef46 100644 (file)
@@ -228,6 +228,9 @@ do_install() {
 
         # required to build scripts/selinux/genheaders/genheaders
         cp -a --parents security/selinux/include/* $kerneldir/build/
+
+       # copy any localversion files
+       cp -a localversion* $kerneldir/build/ 2>/dev/null || :
     )
 
     # Make sure the Makefile and version.h have a matching timestamp so that