]> code.ossystems Code Review - openembedded-core.git/commitdiff
pulseaudio: don't include consolekit when systemd is enabled
authorAnuj Mittal <anuj.mittal@intel.com>
Fri, 26 Jul 2019 15:03:15 +0000 (23:03 +0800)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Sat, 27 Jul 2019 21:45:24 +0000 (22:45 +0100)
When using systemd, make sure that pulseaudio-server RDEPENDS on
module-systemd-login instead of module-console-kit both of which provide
the same functionality but for different init systems [1][2].

Even though both modules can co-exist, this helps avoid including
consolekit (which has been deprecated) in the images using systemd.

[1] https://www.freedesktop.org/wiki/Software/PulseAudio/Documentation/User/Modules/#index51h3
[2] https://github.com/pulseaudio/pulseaudio/commit/860d1cf3a76701ade38784822abb24285176227c

Signed-off-by: Anuj Mittal <anuj.mittal@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-multimedia/pulseaudio/pulseaudio.inc

index e245be7f77d566270960ed174c12f741edbd8cb7..ec51d8b2799338ef44522c137ed31c3b39377274 100644 (file)
@@ -259,9 +259,12 @@ FILES_${PN}-module-gsettings += "${libexecdir}/pulse/gsettings-helper ${datadir}
 # modules must be installed when X11 is enabled.
 RDEPENDS_pulseaudio-server += "\
         ${@bb.utils.contains('DISTRO_FEATURES', 'x11', '\
-                pulseaudio-module-console-kit \
                 pulseaudio-module-device-manager \
                 pulseaudio-module-x11-cork-request \
                 pulseaudio-module-x11-publish \
                 pulseaudio-module-x11-xsmp \
         ', '', d)}"
+
+RDEPENDS_pulseaudio-server += "${@bb.utils.contains('DISTRO_FEATURES', 'x11', \
+                                  bb.utils.contains('DISTRO_FEATURES', 'systemd', 'pulseaudio-module-systemd-login', 'pulseaudio-module-console-kit', d), \
+                                  '', d)}"