]> code.ossystems Code Review - openembedded-core.git/commitdiff
oeqa/selftest/imagefeatures: improve test_hypervisor_fmts
authorRoss Burton <ross.burton@intel.com>
Wed, 9 Oct 2019 11:00:51 +0000 (12:00 +0100)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Wed, 9 Oct 2019 13:02:56 +0000 (14:02 +0100)
If this test fails then the output doesn't help in any meaningful way, so
improve the test to output the unparsable JSON and display unexpected output.

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/lib/oeqa/selftest/cases/imagefeatures.py

index 8213d63e375430f159dcaf554b42d990adf0b73c..cf2a42aab5c77837454703311c2367d64a18fb08 100644 (file)
@@ -161,8 +161,12 @@ class ImageFeatures(OESelftestTestCase):
             sysroot = get_bb_var('STAGING_DIR_NATIVE', 'core-image-minimal')
             result = runCmd('qemu-img info --output json %s' % image_path,
                             native_sysroot=sysroot)
-            self.assertTrue(json.loads(result.output).get('format') == itype,
-                            msg="Could not parse '%s'" % result.output)
+            try:
+                data = json.loads(result.output)
+                self.assertEqual(data.get('format'), itype,
+                                 msg="Unexpected format in '%s'" % (result.output))
+            except json.decoder.JSONDecodeError:
+                self.fail("Could not parse '%ss'" % result.output)
 
     def test_long_chain_conversion(self):
         """