]> code.ossystems Code Review - openembedded-core.git/commitdiff
terminal.py: do not stop searching for auto
authorJoe Slater <joe.slater@windriver.com>
Thu, 21 May 2020 18:41:07 +0000 (11:41 -0700)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Wed, 27 May 2020 09:47:09 +0000 (10:47 +0100)
If a terminal fails to spawn() we should continue looking.
gnome-terminal, in particular can be present but not start.

Signed-off-by: Joe Slater <joe.slater@windriver.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/lib/oe/terminal.py

index a1daa2bed65c844f7938c4e585bbb777b49f0f5d..eb10a6e33e58563cdac7f6d643d2177e2d5d5925 100644 (file)
@@ -207,7 +207,10 @@ def spawn_preferred(sh_cmd, title=None, env=None, d=None):
             spawn(terminal.name, sh_cmd, title, env, d)
             break
         except UnsupportedTerminal:
-            continue
+            pass
+        except:
+            bb.warn("Terminal %s is supported but did not start" % (terminal.name))
+    # when we've run out of options
     else:
         raise NoSupportedTerminals(get_cmd_list())