]> code.ossystems Code Review - openembedded-core.git/commitdiff
libxml2: Security fix for CVE-2016-4449
authorArmin Kuster <akuster@mvista.com>
Sat, 9 Jul 2016 21:59:57 +0000 (14:59 -0700)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Wed, 27 Jul 2016 07:29:37 +0000 (08:29 +0100)
Affects limbxml2 < 2.9.4

Signed-off-by: Armin Kuster <akuster@mvista.com>
meta/recipes-core/libxml/libxml2/CVE-2016-4449.patch [new file with mode: 0644]
meta/recipes-core/libxml/libxml2_2.9.2.bb

diff --git a/meta/recipes-core/libxml/libxml2/CVE-2016-4449.patch b/meta/recipes-core/libxml/libxml2/CVE-2016-4449.patch
new file mode 100644 (file)
index 0000000..f76bb10
--- /dev/null
@@ -0,0 +1,47 @@
+From b1d34de46a11323fccffa9fadeb33be670d602f5 Mon Sep 17 00:00:00 2001
+From: Daniel Veillard <veillard@redhat.com>
+Date: Mon, 14 Mar 2016 17:19:44 +0800
+Subject: [PATCH] Fix inappropriate fetch of entities content
+
+For https://bugzilla.gnome.org/show_bug.cgi?id=761430
+
+libfuzzer regression testing exposed another case where the parser would
+fetch content of an external entity while not in validating mode.
+Plug that hole
+
+Upstream-status: Backport
+CVE: CVE-2016-4449
+
+Signed-off-by: Armin Kuster <akuster@mvista.com>
+
+---
+ parser.c | 16 +++++++++++++++-
+ 1 file changed, 15 insertions(+), 1 deletion(-)
+
+Index: libxml2-2.9.2/parser.c
+===================================================================
+--- libxml2-2.9.2.orig/parser.c
++++ libxml2-2.9.2/parser.c
+@@ -2873,7 +2873,21 @@ xmlStringLenDecodeEntities(xmlParserCtxt
+               ctxt->nbentities += ent->checked / 2;
+           if (ent != NULL) {
+                 if (ent->content == NULL) {
+-                  xmlLoadEntityContent(ctxt, ent);
++                  /*
++                   * Note: external parsed entities will not be loaded,
++                   * it is not required for a non-validating parser to
++                   * complete external PEreferences coming from the
++                   * internal subset
++                   */
++                  if (((ctxt->options & XML_PARSE_NOENT) != 0) ||
++                      ((ctxt->options & XML_PARSE_DTDVALID) != 0) ||
++                      (ctxt->validate != 0)) {
++                      xmlLoadEntityContent(ctxt, ent);
++                  } else {
++                      xmlWarningMsg(ctxt, XML_ERR_ENTITY_PROCESSING,
++                "not validating will not read content for PE entity %s\n",
++                                    ent->name, NULL);
++                  }
+               }
+               ctxt->depth++;
+               rep = xmlStringDecodeEntities(ctxt, ent->content, what,
index 798337cb8bb90f2a41995eaabe8e60803e81a640..10e4b563f3de8dbe9ddf5f1db4d398396cea8c7d 100644 (file)
@@ -12,6 +12,7 @@ SRC_URI += "file://CVE-2016-1762.patch \
             file://CVE-2016-1838.patch \
             file://CVE-2016-1839.patch \
             file://CVE-2016-1836.patch \
+            file://CVE-2016-4449.patch \
     "
 
 SRC_URI[libtar.md5sum] = "9e6a9aca9d155737868b3dc5fd82f788"