]> code.ossystems Code Review - openembedded-core.git/commitdiff
base.bbclass: fix nondeterministic PACKAGECONFIG processing order
authorChristopher Larson <kergoth@gmail.com>
Wed, 23 Oct 2013 20:47:27 +0000 (13:47 -0700)
committerRobert Yang <liezhi.yang@windriver.com>
Wed, 11 Dec 2013 02:12:20 +0000 (21:12 -0500)
The PACKAGECONFIG flags were iterated over using dict.items(), but this
returns the items in an undefined order. As this order determines the
EXTRA_OECONF append order, we can get EXTRA_OECONF which are functionally
equivalent, but whose contents differ, resulting in not using shared state
archives we should be using.

(From OE-Core master rev: 843a5dd8f8f0461e286d9fdb3ba55205b4275f88)

Signed-off-by: Christopher Larson <kergoth@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Robert Yang <liezhi.yang@windriver.com>
meta/classes/base.bbclass

index dfa580c5833bd0f8547a9c50c56cc261900f1a43..93bc700a50008f7ca2aceae05b7ec27c8335d714 100644 (file)
@@ -433,7 +433,7 @@ python () {
         extradeps = []
         extrardeps = []
         extraconf = []
-        for flag, flagval in pkgconfigflags.items():
+        for flag, flagval in sorted(pkgconfigflags.items()):
             if flag == "defaultval":
                 continue
             items = flagval.split(",")