]> code.ossystems Code Review - openembedded-core.git/commitdiff
wic: raise WicError instead of calling logger.error
authorEd Bartosh <ed.bartosh@linux.intel.com>
Tue, 21 Feb 2017 15:12:35 +0000 (17:12 +0200)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Sat, 4 Mar 2017 10:42:32 +0000 (10:42 +0000)
Replaced forgotten calls of logger.error with raising
WicError exception. Otherwise errors will be ignored.

Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
scripts/lib/wic/plugins/source/bootimg-pcbios.py
scripts/lib/wic/utils/misc.py

index 74c75a054e2c262bae449553dd6168a428c2eda4..bbc9f473e2962692252f914efac580ba3697b7f0 100644 (file)
@@ -96,8 +96,8 @@ class BootimgPcbiosPlugin(SourcePlugin):
                 logger.debug("Using custom configuration file %s "
                              "for syslinux.cfg", bootloader.configfile)
             else:
-                logger.error("configfile is specified but failed to "
-                             "get it from %s.", bootloader.configfile)
+                raise WicError("configfile is specified but failed to "
+                               "get it from %s." % bootloader.configfile)
 
         if not custom_cfg:
             # Create syslinux configuration using parameters from wks file
index 216ab7b6ce43e2fcb57624015afb36a599c1532f..c941112c630a3881e68e79f77d6b275510e32d5b 100644 (file)
@@ -136,7 +136,7 @@ def exec_native_cmd(cmd_and_args, native_sysroot, catch=3, pseudo=""):
         else:
             msg += "Wic failed to find a recipe to build native %s. Please "\
                    "file a bug against wic.\n" % prog
-        logger.error(msg)
+        raise WicError(msg)
 
     return ret, out