]> code.ossystems Code Review - openembedded-core.git/commitdiff
image: Include psplash only when screen machine feature is enabled
authorKhem Raj <raj.khem@gmail.com>
Mon, 22 Nov 2021 22:27:59 +0000 (14:27 -0800)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Wed, 24 Nov 2021 09:55:05 +0000 (09:55 +0000)
base-image boots in degraded mode when using systems without display
system since there is no fb device detected and pslash service would
fail to start. Removing this image feature means that core-image-base is
complete for headless devices

[RP: tweak the false case so it builds]
Signed-off-by: Khem Raj <raj.khem@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes/image.bbclass

index 6c759fdf7007172a1ac9c99a2f78e9dcf5b11243..8a46b4852cdf7edfb1584b34404543cebeee8203 100644 (file)
@@ -53,7 +53,7 @@ FEATURE_INSTALL_OPTIONAL[vardepvalue] = "${FEATURE_INSTALL_OPTIONAL}"
 
 # Define some very basic feature package groups
 FEATURE_PACKAGES_package-management = "${ROOTFS_PKGMANAGE}"
-SPLASH ?= "psplash"
+SPLASH ?= "${@bb.utils.contains("MACHINE_FEATURES", "screen", "psplash", "", d)}"
 FEATURE_PACKAGES_splash = "${SPLASH}"
 
 IMAGE_INSTALL_COMPLEMENTARY = '${@complementary_globs("IMAGE_FEATURES", d)}'