autotools.bbclass: When configure fails, dump the config.log files the logs

When configure fails, it usually says "see config.log" yet nobody ever shares
the config.log file meaning the person trying to help invariably has to ask
for more information.

This patch dumps all the config.log files into the main bitbake log files when
configure fails, meaning all the information is present to help someone debug
such failures. It does make the log rather larger but this is preferable to
not having enough information in most cases.

[YOCTO #2463]

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

diff --git a/meta/classes/autotools.bbclass b/meta/classes/autotools.bbclass
index 9b36f3c7b607d596ac6b91ecdb0d59e05938b2b0..02b984db639b48d12c6af49d364257b10196d537 100644 (file)
--- a/meta/classes/autotools.bbclass
+++ b/meta/classes/autotools.bbclass
@@ -74,7 +74,14 @@ oe_runconf () {
        cfgscript="${S}/configure"
        if [ -x "$cfgscript" ] ; then
                bbnote "Running $cfgscript ${CONFIGUREOPTS} ${EXTRA_OECONF} $@"
-               ${CACHED_CONFIGUREVARS} $cfgscript ${CONFIGUREOPTS} ${EXTRA_OECONF} "$@" || bbfatal "oe_runconf failed"
+               set +e
+               ${CACHED_CONFIGUREVARS} $cfgscript ${CONFIGUREOPTS} ${EXTRA_OECONF} "$@"
+               if [ "$?" != "0" ]; then
+                       echo "Configure failed. The contents of all config.log files follows to aid debugging"
+                       find ${S} -name config.log -print -exec cat {} \;
+                       bbfatal "oe_runconf failed"
+               fi
+               set -e
        else
                bbfatal "no configure script found at $cfgscript"
        fi