code cleanup for INITRD variable handing

* Remove an unnecessary check
* Instead of ignoring, report the errors

Signed-off-by: Nitin A Kamble <nitin.a.kamble@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>

diff --git a/meta/classes/boot-directdisk.bbclass b/meta/classes/boot-directdisk.bbclass
index 995d3e7fc68e94094c39d17d9184cdaf15442c96..5107d7f8e41918019ee02e465d370691b439a9f5 100644 (file)
--- a/meta/classes/boot-directdisk.bbclass
+++ b/meta/classes/boot-directdisk.bbclass
@@ -76,8 +76,10 @@ boot_direct_populate() {
                rm -f $dest/initrd
                for fs in ${INITRD}
                do
-                       if [ -n "${fs}" ] && [ -s "${fs}" ]; then
+                       if [ -s "${fs}" ]; then
                                cat ${fs} >> $dest/initrd
+                       else
+                               bbfatal "${fs} is invalid. initrd image creation failed."
                        fi
                done
                chmod 0644 $dest/initrd

diff --git a/meta/classes/bootimg.bbclass b/meta/classes/bootimg.bbclass
index 7b3ce6591058efed7061e54ac1b4f2d097ee1c24..859d517dbd5011e3b6340f35435b5531765c805f 100644 (file)
--- a/meta/classes/bootimg.bbclass
+++ b/meta/classes/bootimg.bbclass
@@ -75,6 +75,8 @@ populate() {
                do
                        if [ -s "${fs}" ]; then
                                cat ${fs} >> ${DEST}/initrd
+                       else
+                               bbfatal "${fs} is invalid. initrd image creation failed."
                        fi
                done
                chmod 0644 ${DEST}/initrd