]> code.ossystems Code Review - openembedded-core.git/commitdiff
cronie: use variables instead of hardcoded paths
authorJavier Martinez Canillas <javier@dowhile0.org>
Sun, 5 Aug 2012 19:48:34 +0000 (21:48 +0200)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Mon, 6 Aug 2012 13:19:19 +0000 (14:19 +0100)
It is considered good practice to use the build system provided
variables instead of directly specify hardcoded paths.

Signed-off-by: Javier Martinez Canillas <javier@dowhile0.org>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-extended/cronie/cronie_1.4.8.bb

index 2d256277bc1b497f01386ec610ac9ea175a1c88a..ce59437ecd1764c5cd7ed4e8c9ac72e7f480cab6 100644 (file)
@@ -18,7 +18,7 @@ DEPENDS += "${@base_contains('DISTRO_FEATURES', 'pam', 'libpam', '', d)}"
 RDEPENDS_${PN} = "${@base_contains('DISTRO_FEATURES', 'pam', '${PAM_DEPS}', '', d)}"
 PAM_DEPS = "libpam libpam-runtime pam-plugin-access pam-plugin-loginuid"
 
-PR = "r2"
+PR = "r3"
 
 SRC_URI = "https://fedorahosted.org/releases/c/r/cronie/cronie-${PV}.tar.gz \
            file://crond.init \
@@ -61,14 +61,14 @@ do_install_append () {
        # below setting is necessary to allow normal user using crontab
 
        # setgid for crontab binary
-       chown root:crontab ${D}/usr/bin/crontab
-       chmod 2755 ${D}/usr/bin/crontab
+       chown root:crontab ${D}${bindir}/crontab
+       chmod 2755 ${D}${bindir}/crontab
 
        # allow 'crontab' group write to /var/spool/cron
-       chown root:crontab ${D}/var/spool/cron
-       chmod 770 ${D}/var/spool/cron
+       chown root:crontab ${D}${localstatedir}/spool/cron
+       chmod 770 ${D}${localstatedir}/spool/cron
 
-       chmod 600 ${D}/etc/crontab
+       chmod 600 ${D}${sysconfdir}/crontab
 }
 
 FILES_${PN} += "${sysconfdir}/cron*"