]> code.ossystems Code Review - openembedded-core.git/commitdiff
guile: fix a bashism
authorMing Liu <peter.x.liu@external.atlascopco.com>
Fri, 24 Feb 2017 11:57:31 +0000 (12:57 +0100)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Sat, 4 Mar 2017 23:18:09 +0000 (23:18 +0000)
A following flaw was detected by verify-bashisms script:
......
meta/recipes-devtools/guile/guile_2.0.13.bb
possible bashism in guile_cross_config line 94 ($'...' should be "$(printf '...')"):

   echo '#!'`which ${BUILD_SYS}-guile`$' \\\n--no-auto-compile -e main -s\n!#\n(define %guile-build-info '\'\( \
       > ${B}/guile-config.cross
......

Fixed by removing $'...' from echo command, using a printf instead.

Signed-off-by: Ming Liu <peter.x.liu@external.atlascopco.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
meta/recipes-devtools/guile/guile_2.0.14.bb

index e0350e4aa4b8cbcdc86a5b34023a50a7265c989b..d2306e6a75f6c6bb514af0cda8dd9137dca5e8dc 100644 (file)
@@ -90,7 +90,7 @@ guile_cross_config() {
        then
                # Create guile-config returning target values instead of native values
                install -d ${SYSROOT_DESTDIR}${STAGING_BINDIR_CROSS}
-               echo '#!'`which ${BUILD_SYS}-guile`$' \\\n--no-auto-compile -e main -s\n!#\n(define %guile-build-info '\'\( \
+               printf '#!%s \\\n--no-auto-compile -e main -s\n!#\n(define %%guile-build-info %s(\n' $(which ${BUILD_SYS}-guile) "'" \
                        > ${B}/guile-config.cross
                sed -n -e 's:^[ \t]*{[ \t]*":  (:' \
                        -e 's:",[ \t]*": . ":' \