]> code.ossystems Code Review - openembedded-core.git/commitdiff
oeqa/selftest/buildoptions: Improve ccache test failure output
authorRichard Purdie <richard.purdie@linuxfoundation.org>
Tue, 27 Nov 2018 12:19:39 +0000 (12:19 +0000)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Tue, 27 Nov 2018 22:11:22 +0000 (22:11 +0000)
The current failure mode doesn't show us what the logs actually looked like
and later cleans can lose them. Show the whole log in case of failure
to aid debugging intermittent problems on the autobuilder.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/lib/oeqa/selftest/cases/buildoptions.py

index 4ebfdb712342ee7730bab38bebe20ccb60db6a32..9b87e7fcfcc6ec0e0d87b9731da9ef8eea6d8438 100644 (file)
@@ -40,8 +40,9 @@ class ImageOptionsTests(OESelftestTestCase):
         self.add_command_to_tearDown('bitbake -c clean m4')
         bitbake("m4 -f -c compile")
         log_compile = os.path.join(get_bb_var("WORKDIR","m4"), "temp/log.do_compile")
-        res = runCmd("grep ccache %s" % log_compile, ignore_status=True)
-        self.assertEqual(0, res.status, msg="No match for ccache in m4 log.do_compile. For further details: %s" % log_compile)
+        with open(log_compile, "r") as f:
+            loglines = "".join(f.readlines())
+        self.assertIn("ccache", loglines, msg="No match for ccache in m4 log.do_compile. For further details: %s" % log_compile)
 
     @OETestID(1435)
     def test_read_only_image(self):