]> code.ossystems Code Review - openembedded-core.git/commitdiff
linuxloader/image-prelink/image-mklibs: Fix non-standard path prelinking
authorRichard Purdie <richard.purdie@linuxfoundation.org>
Fri, 4 Mar 2016 16:28:40 +0000 (16:28 +0000)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Mon, 7 Mar 2016 00:10:24 +0000 (00:10 +0000)
Prelinking on x86-64 wasn't working out the box as it uses /lib and
not /lib64 for libs. Prelink was refusing to link as the dynamic loader
didn't match its idea of the right path. Passing in the --dyanmic-linker
option avoids this.

We can share code from image-mklibs so abstract that into a new class,
linuxloader.bbclass.

This does break prelinking of multilib images, I've opened a bug so we
can loop back and fix that problem, the code would need to iterate the
dynamic loaders (and setup ld.so.conf files for it).

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes/image-mklibs.bbclass
meta/classes/image-prelink.bbclass
meta/classes/linuxloader.bbclass [new file with mode: 0644]

index cfb3ffc91e577c81c24ae5dfec0c76d2962e8824..6c0e8dcf35d9568ad1eeb448b821c98ba6de69e5 100644 (file)
@@ -2,6 +2,8 @@ do_rootfs[depends] += "mklibs-native:do_populate_sysroot"
 
 IMAGE_PREPROCESS_COMMAND += "mklibs_optimize_image; "
 
+inherit linuxloader
+
 mklibs_optimize_image_doit() {
        rm -rf ${WORKDIR}/mklibs
        mkdir -p ${WORKDIR}/mklibs/dest
@@ -15,26 +17,7 @@ mklibs_optimize_image_doit() {
                | sed "s+^\./++" \
                > ${WORKDIR}/mklibs/executables.list
 
-       case ${TARGET_ARCH} in
-               powerpc | mips | mipsel | microblaze )
-                       dynamic_loader="${base_libdir}/ld.so.1"
-                       ;;
-               powerpc64)
-                       dynamic_loader="${base_libdir}/ld64.so.1"
-                       ;;
-               x86_64)
-                       dynamic_loader="${base_libdir}/ld-linux-x86-64.so.2"
-                       ;;
-               i*86 )
-                       dynamic_loader="${base_libdir}/ld-linux.so.2"
-                       ;;
-               arm )
-                       dynamic_loader="${base_libdir}/ld-linux.so.3"
-                       ;;
-               * )
-                       dynamic_loader="/unknown_dynamic_linker"
-                       ;;
-       esac
+       dynamic_loader=$(linuxloader)
 
        mklibs -v \
                --ldlib ${dynamic_loader} \
index 53c4b0b112d9ef09a15fe09c2390857cf037c743..e153f478812383b3269b9a39db2c90b583680b09 100644 (file)
@@ -6,6 +6,8 @@ python prelink_setup () {
     oe.utils.write_ld_so_conf(d)
 }
 
+inherit linuxloader
+
 prelink_image () {
 #      export PSEUDO_DEBUG=4
 #      /bin/env | /bin/grep PSEUDO
@@ -31,8 +33,10 @@ prelink_image () {
        fi
        cat ${STAGING_DIR_TARGET}${sysconfdir}/ld.so.conf >> $ldsoconf
 
+       dynamic_loader=$(linuxloader)
+
        # prelink!
-       ${STAGING_DIR_NATIVE}${sbindir_native}/prelink --root ${IMAGE_ROOTFS} -amR -N -c ${sysconfdir}/prelink.conf
+       ${STAGING_DIR_NATIVE}${sbindir_native}/prelink --root ${IMAGE_ROOTFS} -amR -N -c ${sysconfdir}/prelink.conf --dynamic-linker $dynamic_loader
 
        # Remove the prelink.conf if we had to add it.
        if [ "$dummy_prelink_conf" = "true" ]; then
diff --git a/meta/classes/linuxloader.bbclass b/meta/classes/linuxloader.bbclass
new file mode 100644 (file)
index 0000000..5c4dc5c
--- /dev/null
@@ -0,0 +1,24 @@
+
+linuxloader () {
+       case ${TARGET_ARCH} in
+               powerpc | mips | mipsel | microblaze )
+                       dynamic_loader="${base_libdir}/ld.so.1"
+                       ;;
+               powerpc64)
+                       dynamic_loader="${base_libdir}/ld64.so.1"
+                       ;;
+               x86_64)
+                       dynamic_loader="${base_libdir}/ld-linux-x86-64.so.2"
+                       ;;
+               i*86 )
+                       dynamic_loader="${base_libdir}/ld-linux.so.2"
+                       ;;
+               arm )
+                       dynamic_loader="${base_libdir}/ld-linux.so.3"
+                       ;;
+               * )
+                       dynamic_loader="/unknown_dynamic_linker"
+                       ;;
+       esac
+       echo $dynamic_loader
+}