]> code.ossystems Code Review - openembedded-core.git/commitdiff
wic: get rid of set_size and set_source_file setters
authorEd Bartosh <ed.bartosh@linux.intel.com>
Thu, 14 Jan 2016 12:12:58 +0000 (14:12 +0200)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Sun, 17 Jan 2016 11:32:19 +0000 (11:32 +0000)
Used size and source_file attributes instead of using
setters. It's more pythonic, clear an consistent.

Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
scripts/lib/wic/plugins/source/bootimg-efi.py
scripts/lib/wic/plugins/source/bootimg-pcbios.py
scripts/lib/wic/plugins/source/isoimage-isohybrid.py

index 35afa30ea6b66f474eaada191f78648c3317f27f..8bfa3a96cee9edea09f652adb2f3ad0905d2c317 100644 (file)
@@ -235,5 +235,5 @@ class BootimgEFIPlugin(SourcePlugin):
         out = exec_cmd(du_cmd)
         bootimg_size = out.split()[0]
 
-        part.set_size(bootimg_size)
-        part.set_source_file(bootimg)
+        part.size = bootimg_size
+        part.source_file = bootimg
index 255684b38691ee530e33f8a8bb2182135fcd9a5e..e84bddf15de401a64a40e19bda90403e8013b6a0 100644 (file)
@@ -205,7 +205,7 @@ class BootimgPcbiosPlugin(SourcePlugin):
         out = exec_cmd(du_cmd)
         bootimg_size = out.split()[0]
 
-        part.set_size(bootimg_size)
-        part.set_source_file(bootimg)
+        part.size = int(out.split()[0])
+        part.source_file = bootimg
 
 
index b5ca4d39f6a9ab360f81a0a60da45e53d0ed8e86..daefff39275e46881d3c7be07b8fa01d5a929fba 100644 (file)
@@ -302,7 +302,7 @@ class IsoImagePlugin(SourcePlugin):
             # which contains rootfs
             du_cmd = "du -bks %s" % rootfs_dir
             out = exec_cmd(du_cmd)
-            part.set_size(int(out.split()[0]))
+            part.size = int(out.split()[0])
             part.extra_space = 0
             part.overhead_factor = 1.2
             part.prepare_rootfs(cr_workdir, oe_builddir, rootfs_dir, \
@@ -502,8 +502,8 @@ class IsoImagePlugin(SourcePlugin):
         out = exec_cmd(du_cmd)
         isoimg_size = int(out.split()[0])
 
-        part.set_size(isoimg_size)
-        part.set_source_file(iso_img)
+        part.size = isoimg_size
+        part.source_file = iso_img
 
     @classmethod
     def do_install_disk(cls, disk, disk_name, creator, workdir, oe_builddir,