]> code.ossystems Code Review - openembedded-core.git/commitdiff
image.bbclass: use max() instead of indexing booleans
authorRoss Burton <ross.burton@intel.com>
Tue, 12 Apr 2016 10:44:25 +0000 (11:44 +0100)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Wed, 13 Apr 2016 09:12:44 +0000 (10:12 +0100)
There's some code dotted around OE that uses (a, b)[foo < bar] instead of the
more idiomatic "test and a or b".  Or in this case, just max().

Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes/image.bbclass

index ea77ab8878e0470475d63535a7fa00b1f47589fe..039feec79203e9c3e17783c0a25d218345338466 100644 (file)
@@ -455,8 +455,7 @@ def get_rootfs_size(d):
                                       d.getVar('IMAGE_ROOTFS', True)])
     size_kb = int(output.split()[0])
     base_size = size_kb * overhead_factor
-    base_size = (base_size, rootfs_req_size)[base_size < rootfs_req_size] + \
-        rootfs_extra_space
+    base_size = max(base_size, rootfs_req_size) + rootfs_extra_space
 
     if base_size != int(base_size):
         base_size = int(base_size + 1)
@@ -544,4 +543,3 @@ do_bundle_initramfs () {
        :
 }
 addtask bundle_initramfs after do_image_complete
-