]> code.ossystems Code Review - openembedded-core.git/commitdiff
glibc: Avoid multilibbing on wordsize.h
authorDaniel Díaz <daniel.diaz@linaro.org>
Thu, 26 Jul 2018 14:39:26 +0000 (09:39 -0500)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Sun, 29 Jul 2018 23:02:46 +0000 (00:02 +0100)
Once another header #includes <bits/wordsize.h>, there is a
potential recursion going on because the
multilib_header_wrapper.h #includes <bits/wordsize.h> again!

This should not happen because an __arm__ (32-bits) or an
__aarch64__ (64-bits) environment guarantees that we will
be getting the correct definition, but when building against
a different target (like BPF), recursion is what happens.

This can be seen, for instance, when building eBPF programs
from the kernel with `clang -target bpf', such as the ones
located in linux/tools/testing/selftests/bpf/.

(From OE-Core rev: a74c77d6168101e88c3a3bce7130f4f52cfab95d)

Signed-off-by: Daniel Díaz <daniel.diaz@linaro.org>
Signed-off-by: Aníbal Limón <anibal.limon@linaro.org>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
meta/recipes-core/glibc/glibc-package.inc

index 728bc5381fd141ea06f7a286f6894ccf68cca901..35f5231746b0a2365a5016ddb1bea67f3b53d185 100644 (file)
@@ -137,8 +137,7 @@ do_install_append_armeb () {
 }
 
 do_install_armmultilib () {
-
-       oe_multilib_header bits/endian.h bits/fcntl.h bits/fenv.h bits/fp-fast.h bits/hwcap.h bits/ipc.h bits/link.h bits/wordsize.h
+       oe_multilib_header bits/endian.h bits/fcntl.h bits/fenv.h bits/fp-fast.h bits/hwcap.h bits/ipc.h bits/link.h
        oe_multilib_header bits/local_lim.h bits/mman.h bits/msq.h bits/pthreadtypes.h bits/pthreadtypes-arch.h  bits/sem.h  bits/semaphore.h bits/setjmp.h
        oe_multilib_header bits/shm.h bits/sigstack.h bits/stat.h bits/statfs.h bits/typesizes.h