]> code.ossystems Code Review - openembedded-core.git/commitdiff
classutils.py: deterministic sorting
authorJuro Bystricky <juro.bystricky@intel.com>
Mon, 10 Apr 2017 20:59:36 +0000 (13:59 -0700)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Mon, 10 Apr 2017 23:57:07 +0000 (00:57 +0100)
The method "prioritized" returns a list sorted by the value
of the "priority" field, in descending order. However, if several
list items have the same priority, the ordering of those items
within the priority-sorted list becomes random. As a consequence,
we may end up with a non-deterministic oe-terminal spawning, as several
terminals have the same priority. So running commands such as

$ bitbake xxx -cdevshell
$ bitbake yyy -cmenuconfig

may spawn a different terminal each time, for example sometimes Gnome
and sometimes Konsole as hey have the same priority.
Rather than modifying the priorities so they all differ, we sub-sort
the list based on (terminal) names.
This way we achieve a deterministic outcome.

[YOCTO#10938]

Signed-off-by: Juro Bystricky <juro.bystricky@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/lib/oe/classutils.py

index e7856c86f2833abb6fac488e4159a6ab969d0df6..45cd5249becdf75bd84c479fc59c4c6c9e36c999 100644 (file)
@@ -36,7 +36,7 @@ abstract base classes out of the registry)."""
     @classmethod
     def prioritized(tcls):
         return sorted(list(tcls.registry.values()),
-                      key=lambda v: v.priority, reverse=True)
+                      key=lambda v: (v.priority, v.name), reverse=True)
 
     def unregister(cls):
         for key in cls.registry.keys():