]> code.ossystems Code Review - openembedded-core.git/commitdiff
eglibc: check for required distro features
authorChen Qi <Qi.Chen@windriver.com>
Thu, 3 Jul 2014 03:23:42 +0000 (11:23 +0800)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Thu, 17 Jul 2014 11:27:37 +0000 (12:27 +0100)
If users accidently override the DISTRO_FEATURES in local.conf,
then build failures occur for lack of libc functions.

All features in DISTRO_FEATURES_LIBC should be in DISTRO_FEATURES.
That's why this patch let the recipe inherit distro_features_check
class and set REQUIRED_DISTRO_FEATURES to "${DISTRO_FEATURES_LIBC}".

[YOCTO #6381]

Signed-off-by: Chen Qi <Qi.Chen@windriver.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
meta/recipes-core/eglibc/eglibc.inc

index 68128e975561ad9a04adb2a393a891479abd37b6..af7f6adefcf3cc9e940fcb773857ed29d51ca2b1 100644 (file)
@@ -38,9 +38,14 @@ DEPENDS = "virtual/${TARGET_PREFIX}gcc-initial libgcc-initial linux-libc-headers
 #RDEPENDS_${PN} += "${@['','libgcc']['nptl' in '${GLIBC_ADDONS}']}"
 PROVIDES = "virtual/libc virtual/${TARGET_PREFIX}libc-for-gcc"
 PROVIDES += "virtual/libintl virtual/libiconv"
-inherit autotools texinfo
+inherit autotools texinfo distro_features_check
 require eglibc-options.inc
 
+# The main purpose of setting this variable is to prevent users from accidently
+# overriding DISTRO_FEATRUES, causing obscure build failures because of lack
+# of libc functions.
+REQUIRED_DISTRO_FEATURES = "${DISTRO_FEATURES_LIBC}"
+
 LEAD_SONAME = "libc.so"
 
 CACHED_CONFIGUREVARS += " \