]> code.ossystems Code Review - openembedded-core.git/commitdiff
shadow: improve reproducibility by hard-coding shell path
authorMartin Hundebøll <martin@geanix.com>
Thu, 15 Nov 2018 09:12:48 +0000 (10:12 +0100)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Wed, 5 Dec 2018 22:31:31 +0000 (22:31 +0000)
The shadow configure script tries really hard to detect the running
shell to make sure it doesn't do unsupported calls.

On my system the shell is detected as /bin/sh, while a build in an
ubuntu docker it resolves to /bin/bash. And since the shell path is
baked into the target binaries through config.h, the build becomes
inreproducible.

Fix reproducibility by hard-coding the shell to be /bin/sh

(From OE-Core rev: 5f4fe91cb6c21cd3ecd0b68d1c6b46a9530c7570)

Signed-off-by: Martin Hundebøll <martin@geanix.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Armin Kuster <akuster808@gmail.com>
meta/recipes-extended/shadow/shadow.inc

index 9691c3879a6376b39a0fe9827a8ec2285e98ca3a..4e1eaed9b4da872199ac920ee69a1a4231438ce8 100644 (file)
@@ -53,6 +53,8 @@ PAM_SRC_URI = "file://pam.d/chfn \
 
 inherit autotools gettext
 
+export CONFIG_SHELL="/bin/sh"
+
 EXTRA_OECONF += "--without-audit \
                  --without-libcrack \
                  --without-selinux \