]> code.ossystems Code Review - openembedded-core.git/commitdiff
selftest/prservice: Improve test failure message
authorRichard Purdie <richard.purdie@linuxfoundation.org>
Tue, 1 Sep 2020 22:41:15 +0000 (23:41 +0100)
committerSteve Sakoman <steve@sakoman.com>
Thu, 3 Sep 2020 03:14:46 +0000 (17:14 -1000)
When failing, give more information about why exactly a failure is
happening such as the PR values in question.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit bdd3abcc210e8f58b7b411da6bbd9c5314819908)
Signed-off-by: Steve Sakoman <steve@sakoman.com>
meta/lib/oeqa/selftest/cases/prservice.py

index fe1f24ea6d6b399a053fb5ad96e9aa9cb5aa5f9a..85b534963dbd3a33aa93557a1381d936eedb8d28 100644 (file)
@@ -63,7 +63,7 @@ class BitbakePrTests(OESelftestTestCase):
         pr_2 = self.get_pr_version(package_name)
         stamp_2 = self.get_task_stamp(package_name, track_task)
 
-        self.assertTrue(pr_2 - pr_1 == 1, "Step between same pkg. revision is greater than 1")
+        self.assertTrue(pr_2 - pr_1 == 1, "Step between pkg revisions is not 1 (was %s - %s)" % (pr_2, pr_1))
         self.assertTrue(stamp_1 != stamp_2, "Different pkg rev. but same stamp: %s" % stamp_1)
 
     def run_test_pr_export_import(self, package_name, replace_current_db=True):
@@ -89,7 +89,7 @@ class BitbakePrTests(OESelftestTestCase):
         self.increment_package_pr(package_name)
         pr_2 = self.get_pr_version(package_name)
 
-        self.assertTrue(pr_2 - pr_1 == 1, "Step between same pkg. revision is greater than 1")
+        self.assertTrue(pr_2 - pr_1 == 1, "Step between pkg revisions is not 1 (was %s - %s)" % (pr_2, pr_1))
 
     def test_import_export_replace_db(self):
         self.run_test_pr_export_import('m4')