]> code.ossystems Code Review - openembedded-core.git/commitdiff
rootfs: improve postinst intercept logging
authorRoss Burton <ross.burton@intel.com>
Mon, 4 Sep 2017 20:13:17 +0000 (21:13 +0100)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Mon, 11 Sep 2017 16:30:09 +0000 (17:30 +0100)
Ensure we capture stderr, always write the output to the log, and don't be so
emotional in the warning message.

Signed-off-by: Ross Burton <ross.burton@intel.com>
meta/lib/oe/rootfs.py

index 96591f370e63989500aba75a9c292ab00bf5bd30..9d4727e76c15ad741f67c493513cc27769b13313 100644 (file)
@@ -302,10 +302,11 @@ class Rootfs(object, metaclass=ABCMeta):
             bb.note("> Executing %s intercept ..." % script)
 
             try:
-                subprocess.check_output(script_full)
+                output = subprocess.check_output(script_full, stderr=subprocess.STDOUT)
+                if output: bb.note(output.decode("utf-8"))
             except subprocess.CalledProcessError as e:
-                bb.warn("The postinstall intercept hook '%s' failed (exit code: %d)! See log for details! (Output: %s)" %
-                        (script, e.returncode, e.output))
+                bb.warn("The postinstall intercept hook '%s' failed, details in log.do_rootfs" % script)
+                bb.note("Exit code %d. Output:\n%s" % (e.returncode, e.output.decode("utf-8")))
 
                 with open(script_full) as intercept:
                     registered_pkgs = None