]> code.ossystems Code Review - openembedded-core.git/commitdiff
devshell.bbclass: fix double unbuffering
authorEd Bartosh <ed.bartosh@linux.intel.com>
Mon, 4 Jul 2016 22:08:13 +0000 (01:08 +0300)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Fri, 8 Jul 2016 08:55:39 +0000 (09:55 +0100)
stdout is already unbuffered in bitbake code. Attempt to
do it again in devshell.bbclass causes this crash when
running devpyshell:
  File "scripts/oepydevshell-internal.py", line 29, in <module>
      pty = open(sys.argv[1], "w+b", 0)
  IOError: [Errno 13] Permission denied: '/dev/pts/6'

Signed-off-by: Ed Bartosh <ed.bartosh@linux.intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes/devshell.bbclass

index 341d9c0002a20eae3cf777e7ed3c643649d7b28b..041ed15d461bde6420468928d028e15edd800c6a 100644 (file)
@@ -65,7 +65,6 @@ def devpyshell(d):
         os.dup2(m, sys.stdout.fileno())
         os.dup2(m, sys.stderr.fileno())
 
-        sys.stdout = os.fdopen(sys.stdout.fileno(), 'w', 0)
         sys.stdin = os.fdopen(sys.stdin.fileno(), 'r', 0)
 
         bb.utils.nonblockingfd(sys.stdout)