]> code.ossystems Code Review - openembedded-core.git/commitdiff
base.bbclass: fix PACKAGECONFIG handling code
authorYao Zhao <yao.zhao@windriver.com>
Thu, 2 Aug 2012 16:06:36 +0000 (12:06 -0400)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Sun, 19 Aug 2012 09:31:08 +0000 (10:31 +0100)
PACKAGECONFIG flag code only handles that when it has 3 or 4 items in flag,
it may have a stale data if some flags doesn't need DEPENDS and RDEPENDS.

Signed-off-by: Yao Zhao <yao.zhao@windriver.com>
Signed-off-by: Saul Wold <sgw@linux.intel.com>
meta/classes/base.bbclass

index acc3217b394a4b34f408f76f3ff62b746192801c..1a094ad38471b6d2aa2359099ddda98315341a10 100644 (file)
@@ -382,20 +382,19 @@ python () {
             if flag == "defaultval":
                 continue
             items = flagval.split(",")
-            if len(items) == 3:
-                enable, disable, depend = items
-                rdepend = ""
-            elif len(items) == 4:
-                enable, disable, depend, rdepend = items
+            num = len(items)
+            if num > 4:
+                bb.error("Only enable,disable,depend,rdepend can be specified!")
+
             if flag in pkgconfig:
-                if depend:
-                    extradeps.append(depend)
-                if rdepend:
-                    extrardeps.append(rdepend)
-                if enable:
-                    extraconf.append(enable)
-            elif disable:
-                    extraconf.append(disable)
+                if num >= 3 and items[2]:
+                    extradeps.append(items[2])
+                if num >= 4 and items[3]:
+                    extrardeps.append(items[3])
+                if num >= 1 and items[0]:
+                    extraconf.append(items[0])
+            elif num >= 2 and items[1]:
+                    extraconf.append(items[1])
         appendVar('DEPENDS', extradeps)
         appendVar('RDEPENDS_${PN}', extrardeps)
         appendVar('EXTRA_OECONF', extraconf)