]> code.ossystems Code Review - openembedded-core.git/commitdiff
wic: remove useless calls to __write_fstab
authorAlexandre Belloni <alexandre.belloni@free-electrons.com>
Sun, 8 Feb 2015 23:16:24 +0000 (00:16 +0100)
committerOtavio Salvador <otavio@ossystems.com.br>
Wed, 18 Mar 2015 04:10:36 +0000 (01:10 -0300)
__write_fstab() is already iterating over parts. There is now need to
call it fort each parts.

Change-Id: I7cf315a6b25c30ffc24baf90402df3c9f5026058
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
Signed-off-by: Otavio Salvador <otavio@ossystems.com.br>
scripts/lib/wic/imager/direct.py

index 38d4e78e627332bac5ec3598c91213a225f1393b..c605e642382607e6da13342f848822168fe0ee01 100644 (file)
@@ -136,7 +136,7 @@ class DirectImageCreator(BaseImageCreator):
             fstab_lines.append(fstab_entry)
 
     def _write_fstab(self, fstab, fstab_lines):
-        fstab = open(fstab, "w")
+        fstab = open(fstab + ".new", "w")
         for line in fstab_lines:
             fstab.write(line)
         fstab.close()
@@ -258,12 +258,9 @@ class DirectImageCreator(BaseImageCreator):
             # self.assemble() calls Image.assemble() which calls
             # __write_partitition() for each partition to dd the fs
             # into the partitions.
-            fstab = self.__write_fstab(self.rootfs_dir.get("ROOTFS_DIR"))
-
             p.prepare(self, self.workdir, self.oe_builddir, self.rootfs_dir,
                       self.bootimg_dir, self.kernel_dir, self.native_sysroot)
 
-            self._restore_fstab(fstab)
 
             self.__image.add_partition(int(p.size),
                                        p.disk,
@@ -277,6 +274,9 @@ class DirectImageCreator(BaseImageCreator):
                                        no_table = p.no_table,
                                        part_type = p.part_type)
 
+        fstab = self.__write_fstab(self.rootfs_dir.get("ROOTFS_DIR"))
+        self._restore_fstab(fstab)
+
         self.__image.layout_partitions(self._ptable_format)
 
         self.__imgdir = self.workdir