]> code.ossystems Code Review - openembedded-core.git/commitdiff
classes/archiver: Create patched archive before configuring
authorJoshua Watt <JPEWhacker@gmail.com>
Tue, 16 Jun 2020 14:39:17 +0000 (09:39 -0500)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Wed, 17 Jun 2020 10:09:28 +0000 (11:09 +0100)
do_configure and do_preconfigure can modify source files, which causes
race conditions if these tasks run in parallel with do_ar_patched. Add
explicit task dependencies to ensure that do_ar_patched finishes before
these tasks start. Specifically, this fixes a race condition with
gcc-source where do_ar_patched races with do_preconfigure deleting
gcc/gengtype-lex.c

Signed-off-by: Joshua Watt <JPEWhacker@gmail.com>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes/archiver.bbclass

index c2c049c343d743e776155d67fff3b1e49dc8b0b1..e221fff695351e44f76b226c870f2f19da270e8c 100644 (file)
@@ -583,7 +583,7 @@ addtask do_deploy_archives_setscene
 
 addtask do_ar_original after do_unpack
 addtask do_unpack_and_patch after do_patch
-addtask do_ar_patched after do_unpack_and_patch
+addtask do_ar_patched after do_unpack_and_patch before do_preconfigure do_configure
 addtask do_ar_configured after do_unpack_and_patch
 addtask do_ar_mirror after do_fetch
 addtask do_dumpdata