]> code.ossystems Code Review - openembedded-core.git/commitdiff
sysvinit-inittab: start_getty: consider whitespaces in tty driver name
authorAndrea Adami <andrea.adami@gmail.com>
Fri, 15 Sep 2017 23:35:49 +0000 (01:35 +0200)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Thu, 21 Sep 2017 08:23:59 +0000 (09:23 +0100)
Unbreak serial console when driver name contains spaces (PXA serial).

Fix commit ac0e954
"start_getty: Over added SERIAL_CONSOLE cause error in userspace log"

Signed-off-by: Andrea Adami <andrea.adami@gmail.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
meta/recipes-core/sysvinit/sysvinit-inittab/start_getty

index 31b44134338737381eb5c41846e8bb2a1e4e7078..f0d9f8cbcff38c479f4bdbfe9d2566fe9443ef63 100644 (file)
@@ -8,21 +8,26 @@
 ####################################################################################
 
 # Get active serial filename.
-active_serial=$(grep "serial" /proc/tty/drivers | grep -oh "^\s*\S*")
+active_serial=$(grep "serial" /proc/tty/drivers | cut -d/ -f1 | sed "s/ *$//")
 
 # Re-phrase input parameter from ttyS target index (ttyS1, ttyS2, ttyAMA0, etc).
 runtime_tty=$(echo $2 | grep -oh '[0-9]')
 
+# Backup $IFS.
+DEFAULT_IFS=$IFS
+# Customize Internal Field Separator.
+IFS="$(printf '\n\t')"
+
 for line in $active_serial; do
        # File is availability, file content current active serial target index.
-       if [ -e /proc/tty/driver/$line ]
+       if [ -e "/proc/tty/driver/$line" ]
         then
                # File content a lot of unknown serial. We use -v to remove all unmatch and get left off.
                # Tail use to avoid 1st line included into the filter because 1st line is file description.
-               activetty=$(grep -v "unknown" /proc/tty/driver/$line | tail -n +2 | grep -oh "^\s*\S*[0-9]")
+               activetty=$(grep -v "unknown" "/proc/tty/driver/$line" | tail -n +2 | grep -oh "^\s*\S*[0-9]")
                for active in $activetty; do
                        # Check if both index is match then proceed to enable the serial console.
-                       if [ $active -eq $runtime_tty ] 
+                       if [ $active -eq $runtime_tty ]
                        then
                                if [ -c /dev/$2 ]
                                then
@@ -33,3 +38,6 @@ for line in $active_serial; do
                done
        fi
 done
+
+# Restore $IFS.
+IFS=$DEFAULT_IFS