]> code.ossystems Code Review - openembedded-core.git/commitdiff
mdadm: fix do_package failed when changed local.conf but not cleaned
authorChangqing Li <changqing.li@windriver.com>
Tue, 29 Oct 2019 09:52:30 +0000 (17:52 +0800)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Thu, 31 Oct 2019 16:07:11 +0000 (16:07 +0000)
reproduce steps:
1. add DISTRO_FEATURE_append = 'usrmerge' in local.conf
2. bitbake mdadm --success
3. remove DISTRO_FEATURE_append = 'usrmerge' from local.conf
4. bitbake mdadm  -- failed when do_package

it is not proper to change source Makefile during do_install by sed,
fix by pass correct config to EXTRA_OEMAKE

[YOCTO #13493]

Signed-off-by: Changqing Li <changqing.li@windriver.com>
meta/recipes-extended/mdadm/mdadm_4.1.bb

index 639382e1371f450b05a592d2c7d6f141f695c539..64f519e7502a03a317d2c941bf49d0529b2a4786 100644 (file)
@@ -43,13 +43,12 @@ CFLAGS_append_powerpc64 = ' -D__SANE_USERSPACE_TYPES__'
 CFLAGS_append_mipsarchn64 = ' -D__SANE_USERSPACE_TYPES__'
 CFLAGS_append_mipsarchn32 = ' -D__SANE_USERSPACE_TYPES__'
 
-EXTRA_OEMAKE = 'CHECK_RUN_DIR=0 CXFLAGS="${CFLAGS}"'
+EXTRA_OEMAKE = 'CHECK_RUN_DIR=0 CXFLAGS="${CFLAGS}" SYSTEMD_DIR=${systemd_unitdir}/system \
+                BINDIR="${base_sbindir}" UDEVDIR="${nonarch_base_libdir}/udev"'
 
 DEBUG_OPTIMIZATION_append = " -Wno-error"
 
 do_compile() {
-       # Point to right sbindir
-       sed -i -e "s;BINDIR  = /sbin;BINDIR = $base_sbindir;" -e "s;UDEVDIR = /lib;UDEVDIR = $nonarch_base_libdir;" -e "s;SYSTEMD_DIR=/lib/systemd/system;SYSTEMD_DIR=${systemd_unitdir}/system;" ${S}/Makefile
        oe_runmake SYSROOT="${STAGING_DIR_TARGET}"
 }