]> code.ossystems Code Review - openembedded-core.git/commitdiff
oeqa/qemurunner: Fix binary vs str issue
authorRichard Purdie <richard.purdie@linuxfoundation.org>
Fri, 7 May 2021 17:12:15 +0000 (18:12 +0100)
committerSteve Sakoman <steve@sakoman.com>
Fri, 14 May 2021 17:16:38 +0000 (07:16 -1000)
The recent logging changes for qemurunner showed up as errors on the
autobuilder where decode couldn't be called on the returned string.
Since the code returns binary data, return b'' instead of '' to match
to avoid tracebacks.

One of these cases was newly added, copied from the other which has
been there for a long time, always broken.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
(cherry picked from commit b8995b27db265b0a0b2d2ca595915f70f9f96e07)
Signed-off-by: Steve Sakoman <steve@sakoman.com>
meta/lib/oeqa/utils/qemurunner.py

index 410789b815d23cd1580069f87a3423b7760acb21..09ef9fadb284fbe067e65adf2a9acfd794f79bff 100644 (file)
@@ -646,7 +646,7 @@ class LoggingThread(threading.Thread):
             data = self.readsock.recv(count)
         except socket.error as e:
             if e.errno == errno.EAGAIN or e.errno == errno.EWOULDBLOCK:
-                return ''
+                return b''
             else:
                 raise
 
@@ -659,7 +659,7 @@ class LoggingThread(threading.Thread):
             # until qemu exits.
             if not self.canexit:
                 raise Exception("Console connection closed unexpectedly")
-            return ''
+            return b''
 
         return data