]> code.ossystems Code Review - openembedded-core.git/commitdiff
x264: add textrel to INSANE_SKIP
authorFahad Usman <fahad_usman@mentor.com>
Wed, 21 Sep 2016 09:42:43 +0000 (15:12 +0530)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Thu, 22 Sep 2016 10:08:22 +0000 (11:08 +0100)
Tried by adding CFLAGS_append = " -fpic " to
the recipe. But that couldn't help resolve the
warning message:

x264/r2491+gitAUTOINC+c8a773ebfc-r0/packages-split/x264/usr/lib/libx264.so.144' has relocations in .text [textrel]

It was found that this warning is emitted because of the
assembly files in the source code. And it is not easy to
get rid of TEXTREL's which are coming from the assembly
source files.

Adding textrel to INSANE_SKIP resolves this issue.
This issue was observed in cyclone5 and imx6qsabresd BSP's.
So generalizing the patch.

Signed-off-by: Fahad Usman <fahad_usman@mentor.com>
Signed-off-by: Sujith Haridasan <Sujith_Haridasan@mentor.com>
Signed-off-by: Ross Burton <ross.burton@intel.com>
meta/recipes-multimedia/x264/x264_git.bb

index fa44f9c03febd6a618a55b85fc35032ad9191de1..393310f684b7a4726ec778bb7cb1d3ffefeea93f 100644 (file)
@@ -48,6 +48,6 @@ do_install() {
     oe_runmake install DESTDIR=${D}
 }
 
-# PIC can't be enabled for 32-bit x86
-INSANE_SKIP_${PN}_append_x86 = " textrel"
+# PIC can't be enabled for few BSP's
+INSANE_SKIP_${PN}_append = " textrel"