]> code.ossystems Code Review - openembedded-core.git/commitdiff
vulkan-samples: Disable PCH for reproducibility
authorRichard Purdie <richard.purdie@linuxfoundation.org>
Fri, 15 Jan 2021 15:11:32 +0000 (15:11 +0000)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Sat, 16 Jan 2021 22:39:17 +0000 (22:39 +0000)
We're still seeing reproducibility issues on the autobuilder with this
recipe. I was able to make the output "match" by rebuilding the PCH and
then rebuilding the binary objects, proving the PCH isn't deterministic.

Disable PCH until we can get to the bottom of why that may be.

Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/recipes-graphics/vulkan/vulkan-samples_git.bb

index 447d498fb34bcc120ce32933abe708f401fe47f3..a61dddeb3bb31300da0f4bf79060fcaab51d6305 100644 (file)
@@ -26,4 +26,8 @@ FILES_${PN} += "${datadir}"
 # used for logging with LOGE in the code. We need to make this match the value we use
 # in the debug source remapping from CFLAGS
 #
-EXTRA_OECMAKE = "-DCMAKE_DEBUG_SRCDIR=/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR}/"
\ No newline at end of file
+EXTRA_OECMAKE += "-DCMAKE_DEBUG_SRCDIR=/usr/src/debug/${PN}/${EXTENDPE}${PV}-${PR}/"
+# Binaries built with PCH enabled don't appear reproducible, differing results were seen
+# from some builds depending on the point the PCH was compiled. Disable it to be
+# deterministic
+EXTRA_OECMAKE += "-DCMAKE_DISABLE_PRECOMPILE_HEADERS=ON"