]> code.ossystems Code Review - openembedded-core.git/commitdiff
insane: fix gnu-hash-style check
authorSumit Garg <sumit.garg@linaro.org>
Tue, 1 Sep 2020 12:59:23 +0000 (18:29 +0530)
committerRichard Purdie <richard.purdie@linuxfoundation.org>
Wed, 2 Sep 2020 15:00:40 +0000 (16:00 +0100)
Fix gnu-hash-style check that always returned True after commit [1]
leading to false positive presence of "GNU_HASH" in objdump output.

Fixes: 9ff90bf04a4c ("mips: Enable gnu-hash-style on glibc") [1]
Signed-off-by: Sumit Garg <sumit.garg@linaro.org>
Signed-off-by: Richard Purdie <richard.purdie@linuxfoundation.org>
meta/classes/insane.bbclass

index ee19ef673e07955311e0e6ac4ec55c8bb096598f..c32bf25124d2716d57c227f28afde8aca82f30c6 100644 (file)
@@ -438,7 +438,7 @@ def package_qa_hash_style(path, name, d, elf, messages):
     for line in phdrs.split("\n"):
         if "SYMTAB" in line:
             has_syms = True
-        if "GNU_HASH" or "DT_MIPS_XHASH" in line:
+        if "GNU_HASH" in line or "DT_MIPS_XHASH" in line:
             sane = True
         if ("[mips32]" in line or "[mips64]" in line) and d.getVar('TCLIBC') == "musl":
             sane = True