]> code.ossystems Code Review - openembedded-core.git/commitdiff
classes/package_ipk|_deb.bbclass: Make sure versions correctly make it into output...
authorRichard Purdie <rpurdie@linux.intel.com>
Wed, 30 Jun 2010 08:48:59 +0000 (09:48 +0100)
committerRichard Purdie <rpurdie@linux.intel.com>
Wed, 30 Jun 2010 08:48:59 +0000 (09:48 +0100)
The version information part of package dependency strings was not ending up
in the output packages correctly. This patch fixes this and ensures the version
information isn't lost.

Signed-off-by: Richard Purdie <rpurdie@linux.intel.com>
meta/classes/package_deb.bbclass
meta/classes/package_ipk.bbclass

index 94a07b34819714d1eff883e72b52031258bd8f58..560b7bc9c9ce4669c4bac7caa333246a76afb099 100644 (file)
@@ -196,22 +196,22 @@ python do_package_deb () {
         rdepends = [dep for dep in rdepends if not '*' in dep]
         rrecommends = bb.utils.explode_deps(unicode(bb.data.getVar("RRECOMMENDS", localdata, 1) or ""))
         rrecommends = [rec for rec in rrecommends if not '*' in rec]
-        rsuggests = (unicode(bb.data.getVar("RSUGGESTS", localdata, 1) or "")).split()
-        rprovides = (unicode(bb.data.getVar("RPROVIDES", localdata, 1) or "")).split()
-        rreplaces = (unicode(bb.data.getVar("RREPLACES", localdata, 1) or "")).split()
-        rconflicts = (unicode(bb.data.getVar("RCONFLICTS", localdata, 1) or "")).split()
+        rsuggests = bb.utils.explode_deps(unicode(bb.data.getVar("RSUGGESTS", localdata, 1) or ""))
+        rprovides = bb.utils.explode_deps(unicode(bb.data.getVar("RPROVIDES", localdata, 1) or ""))
+        rreplaces = bb.utils.explode_deps(unicode(bb.data.getVar("RREPLACES", localdata, 1) or ""))
+        rconflicts = bb.utils.explode_deps(unicode(bb.data.getVar("RCONFLICTS", localdata, 1) or ""))
         if rdepends:
-            ctrlfile.write(u"Depends: %s\n" % ", ".join(rdepends))
+            ctrlfile.write(u"Depends: %s\n" %  bb.utils.join_deps(rdepends))
         if rsuggests:
-            ctrlfile.write(u"Suggests: %s\n" % ", ".join(rsuggests))
+            ctrlfile.write(u"Suggests: %s\n" %  bb.utils.join_deps(rsuggests))
         if rrecommends:
-            ctrlfile.write(u"Recommends: %s\n" % ", ".join(rrecommends))
+            ctrlfile.write(u"Recommends: %s\n" %  bb.utils.join_deps(rrecommends))
         if rprovides:
-            ctrlfile.write(u"Provides: %s\n" % ", ".join(rprovides))
+            ctrlfile.write(u"Provides: %s\n" %  bb.utils.join_deps(rprovides))
         if rreplaces:
-            ctrlfile.write(u"Replaces: %s\n" % ", ".join(rreplaces))
+            ctrlfile.write(u"Replaces: %s\n" %  bb.utils.join_deps(rreplaces))
         if rconflicts:
-            ctrlfile.write(u"Conflicts: %s\n" % ", ".join(rconflicts))
+            ctrlfile.write(u"Conflicts: %s\n" %  bb.utils.join_deps(rconflicts))
         ctrlfile.close()
 
         for script in ["preinst", "postinst", "prerm", "postrm"]:
index 04b117b75d22591e7d2b66a0f91f7a54254cea61..da195a99e13d0c709ea84a3a4a7a80b147807c45 100644 (file)
@@ -248,24 +248,25 @@ python do_package_ipk () {
 
                bb.build.exec_func("mapping_rename_hook", localdata)
 
-               rdepends = bb.utils.explode_deps(bb.data.getVar("RDEPENDS", localdata, 1) or "")
-               rrecommends = bb.utils.explode_deps(bb.data.getVar("RRECOMMENDS", localdata, 1) or "")
-               rsuggests = (bb.data.getVar("RSUGGESTS", localdata, 1) or "").split()
-               rprovides = (bb.data.getVar("RPROVIDES", localdata, 1) or "").split()
-               rreplaces = (bb.data.getVar("RREPLACES", localdata, 1) or "").split()
-               rconflicts = (bb.data.getVar("RCONFLICTS", localdata, 1) or "").split()
+               rdepends = bb.utils.explode_dep_versions(bb.data.getVar("RDEPENDS", localdata, 1) or "")
+               rrecommends = bb.utils.explode_dep_versions(bb.data.getVar("RRECOMMENDS", localdata, 1) or "")
+               rsuggests = bb.utils.explode_dep_versions(bb.data.getVar("RSUGGESTS", localdata, 1) or "")
+               rprovides = bb.utils.explode_dep_versions(bb.data.getVar("RPROVIDES", localdata, 1) or "")
+               rreplaces = bb.utils.explode_dep_versions(bb.data.getVar("RREPLACES", localdata, 1) or "")
+               rconflicts = bb.utils.explode_dep_versions(bb.data.getVar("RCONFLICTS", localdata, 1) or "")
+
                if rdepends:
-                       ctrlfile.write("Depends: %s\n" % ", ".join(rdepends))
+                       ctrlfile.write("Depends: %s\n" % bb.utils.join_deps(rdepends))
                if rsuggests:
-                       ctrlfile.write("Suggests: %s\n" % ", ".join(rsuggests))
+                       ctrlfile.write("Suggests: %s\n" % bb.utils.join_deps(rsuggests))
                if rrecommends:
-                       ctrlfile.write("Recommends: %s\n" % ", ".join(rrecommends))
+                       ctrlfile.write("Recommends: %s\n" % bb.utils.join_deps(rrecommends))
                if rprovides:
-                       ctrlfile.write("Provides: %s\n" % ", ".join(rprovides))
+                       ctrlfile.write("Provides: %s\n" % bb.utils.join_deps(rprovides))
                if rreplaces:
-                       ctrlfile.write("Replaces: %s\n" % ", ".join(rreplaces))
+                       ctrlfile.write("Replaces: %s\n" % bb.utils.join_deps(rreplaces))
                if rconflicts:
-                       ctrlfile.write("Conflicts: %s\n" % ", ".join(rconflicts))
+                       ctrlfile.write("Conflicts: %s\n" % bb.utils.join_deps(rconflicts))
                src_uri = bb.data.getVar("SRC_URI", localdata, 1)
                if src_uri:
                        src_uri = re.sub("\s+", " ", src_uri)